Skip to content

Conversation

@yukiiiteru
Copy link
Member

@yukiiiteru yukiiiteru commented Jan 19, 2026

Motivation

Introduce ShmIPC


Note

Introduces optional ShmIPC support in volo-thrift ping-pong transport and wires it through codec, client, and server paths.

  • Adds shmipc feature and shmipc_helper plumbing to Encoder/Decoder and default codec for managing reuse/close semantics
  • Updates ping-pong client/server/transport to reuse/close via ShmIPC; guards against multiplex over ShmIPC and returns an error if attempted
  • Extends server accept loop to reject multiplex when peer is ShmIPC; adds close guards on ShmIPC connections
  • Adds examples binaries: shmipc-thrift-server and shmipc-thrift-client gated by shmipc
  • Bumps versions: volo to 0.12.2, volo-grpc to 0.12.2, volo-http to 0.5.3, volo-thrift to 0.12.1; aligns dependencies
  • Minor: switch some logs to tracing::trace/warn/debug; fix Address hash discriminator for Shmipc

Written by Cursor Bugbot for commit 17cb563. This will update automatically on new commits. Configure here.

@yukiiiteru yukiiiteru requested review from a team as code owners January 19, 2026 04:32
@yukiiiteru yukiiiteru marked this pull request as draft January 19, 2026 04:32
@yukiiiteru yukiiiteru changed the title feat: introduce ShmIPC feat(volo-thrift): support shmipc for pingpong transport Jan 23, 2026
@yukiiiteru yukiiiteru marked this pull request as ready for review January 23, 2026 10:01
@codecov
Copy link

codecov bot commented Jan 23, 2026

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 43.28%. Comparing base (5fdef10) to head (17cb563).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
volo-thrift/src/codec/default/mod.rs 0.00% 6 Missing ⚠️
...-thrift/src/transport/pingpong/thrift_transport.rs 0.00% 2 Missing ⚠️
volo-thrift/src/transport/pingpong/server.rs 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (0.00%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #634      +/-   ##
==========================================
- Coverage   43.44%   43.28%   -0.16%     
==========================================
  Files         160      160              
  Lines       19383    19441      +58     
==========================================
- Hits         8421     8416       -5     
- Misses      10962    11025      +63     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PureWhiteWu
Copy link
Member

bugbot run

Copy link

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

@yukiiiteru yukiiiteru merged commit a7d2463 into cloudwego:main Jan 23, 2026
12 of 15 checks passed
@yukiiiteru yukiiiteru deleted the feat/shmipc branch January 23, 2026 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants