fix(doctor): respect max_file_size when walking project files - #272
Open
shixi-li wants to merge 1 commit into
Open
fix(doctor): respect max_file_size when walking project files#272shixi-li wants to merge 1 commit into
shixi-li wants to merge 1 commit into
Conversation
shixi-li
marked this pull request as ready for review
August 10, 2026 09:20
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
max_file_sizesetting into Doctor's file matcherWhy
max_file_sizeis part of the project matching contract introduced in #248. Indexing andccc grepalready pass it tobuild_matcher, but Doctor's File Walk check omitted the fourth argument. As a result,ccc doctorcould report oversized files as matched even though indexing and grep correctly skipped them.This keeps Doctor's preview consistent with the files the rest of the project actually processes.
Validation
.venv/bin/pytest tests/test_daemon.py::test_file_walk_respects_project_max_file_size tests/test_file_walk.py -k 'file_walk_respects_project_max_file_size or max_file_size' -q— 4 passed.venv/bin/ruff check src/cocoindex_code/daemon.py tests/test_daemon.py.venv/bin/ruff format --check src/cocoindex_code/daemon.py tests/test_daemon.py.venv/bin/mypy src/cocoindex_code/daemon.pyThe locked full dev extra cannot be installed on this macOS x86_64 host because
torch==2.13.0has no compatible wheel; the focused tests above use the base dependency set, and CI can exercise the repository's full Linux matrix.