Conversation
🦋 Changeset detectedLatest commit: af23064 The changes in this PR will be included in the next version bump. This PR includes changesets to release 12 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lorisleiva
left a comment
There was a problem hiding this comment.
Thanks, I've made some important comments but this is a solid base. I'll give it another thorough review after these are addressed.
lorisleiva
left a comment
There was a problem hiding this comment.
Thanks! Another round of comments. 🙏
lorisleiva
left a comment
There was a problem hiding this comment.
Nice, thank you! Just a quick nit and I think we're good to go.
lorisleiva
left a comment
There was a problem hiding this comment.
Thanks! I've just noticed we don't have a documentation page for the new node though. Would you mind adding one under packages/nodes/docs/ErrorNode.md? There should be a _template.md file to help with that. Additionally, the ProgramNode.md page needs updating and so does the main packages/nodes/README.md.
Another thing that would be good to update is the getDefinedTypeHistogramVisitor to ensure it tracks link usages inside event nodes as well.
Added and updated. |
Summary
I added this while making
dynamic-parserssupport full Anchor-format parsing, and I want to upstream the base event support first so that work can stay aligned withmain.This PR adds
EventNodesupport across the core packages and imports Anchoreventsinto the program AST.A follow-up change depends on this.
Changes
EventNodeto node types and node constructorsProgramNode.eventsdefinedTypeseventNodeValidation
pnpm lintpnpm test