feat: add event support to dynamic parsers and codecs#989
Open
daog1 wants to merge 5 commits intocodama-idl:mainfrom
Open
feat: add event support to dynamic parsers and codecs#989daog1 wants to merge 5 commits intocodama-idl:mainfrom
daog1 wants to merge 5 commits intocodama-idl:mainfrom
Conversation
🦋 Changeset detectedLatest commit: 6ac4e23 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lorisleiva
reviewed
Mar 30, 2026
Member
lorisleiva
left a comment
There was a problem hiding this comment.
I'd just like to challenge the usefulness of parseDataByName but the rest is good. Don't forget to add a changeset as well.
lorisleiva
reviewed
Mar 31, 2026
lorisleiva
reviewed
Mar 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds event support to
@codama/dynamic-parsersand the required codec support in@codama/dynamic-codecs.Specifically, it:
EventNodesupport togetNodeCodecidentifyEventDataandparseEventDataidentifyData/parseDatato supporteventNodeparseDataByNameto decode accounts, events, or instructions by namedynamic-parsersAPIsDetails
@codama/dynamic-codecsAdded
EventNodetoEncodableNodesand taughtgetNodeCodecVisitorto delegate event decoding toevent.data, matching the existing account/instruction behavior.@codama/dynamic-parsersAdded:
identifyEventDataparseEventDataparseDataByNameAlso updated event identification so it no longer assumes event payloads are struct-only. This is important because
EventNode.datais a generalTypeNode, and Anchor event payloads may be tuple-based with hidden discriminator prefixes.To support that, discriminator matching was relaxed so:
Tests
Added and updated tests to cover:
dynamic-codecsdynamic-parsersdynamic-parsersValidation
Ran:
pnpm --filter @codama/dynamic-codecs test:typespnpm --filter @codama/dynamic-codecs buildpnpm --filter @codama/dynamic-codecs test:unitpnpm --filter @codama/dynamic-parsers test:typespnpm --filter @codama/dynamic-parsers buildpnpm --filter @codama/dynamic-parsers test:unit