Skip to content

Fix CI pipeline and symlink resolution for 2.0.0 - #6

Merged
gimlichael merged 2 commits into
mainfrom
v2.0.0/fix-main-ci-run
Aug 10, 2026
Merged

Fix CI pipeline and symlink resolution for 2.0.0#6
gimlichael merged 2 commits into
mainfrom
v2.0.0/fix-main-ci-run

Conversation

@gimlichael

Copy link
Copy Markdown
Member
  • Enable macOS tests on pull_request events in CI workflow
  • Fix ContentRootValidator to recursively resolve chained symbolic links
  • Add comprehensive test coverage for symlink chains and root directory cases
  • Update README to clarify multi-OS CI behavior
  • Update CHANGELOG.md with fixes section

This patch improves cross-platform symbolic link traversal and ensures complete test validation across all platforms during pull requests.

- Enable macOS tests on pull_request events in CI workflow
- Fix ContentRootValidator to recursively resolve chained symbolic links
- Add comprehensive test coverage for symlink chains and root directory cases
- Update README to clarify multi-OS CI behavior
- Update CHANGELOG.md with fixes section

This patch improves cross-platform symbolic link traversal and ensures complete test validation across all platforms during pull requests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@greptile-apps

greptile-apps Bot commented Aug 10, 2026

Copy link
Copy Markdown

Greptile Summary

The PR enables macOS validation for pull requests and recursively canonicalizes symbolic-link targets before content-root containment checks.

  • Runs the macOS test matrix automatically for pull-request events while preserving the manual opt-in.
  • Resolves symlink targets whose resulting paths traverse additional symbolic links.
  • Adds root-directory and chained-symlink coverage and updates release documentation.

Confidence Score: 5/5

The PR appears safe to merge because no blocking failure remains in the eligible follow-up review scope.

No blocking failure remains.

Important Files Changed

Filename Overview
.github/workflows/ci-pipeline.yml Extends the macOS test gate to pull-request events while retaining the manual-run input condition.
src/Codebelt.Cdn.Origin/Hosting/ContentRootValidator.cs Recursively canonicalizes the resolved target so symbolic links appearing within the target path are included in containment checks.
test/Codebelt.Cdn.Origin.Tests/Hosting/ContentRootValidatorTest.cs Adds coverage for filesystem roots and symbolic-link targets that traverse another link.
README.md Documents mandatory macOS pull-request testing and optional manually dispatched macOS testing.
CHANGELOG.md Records the symbolic-link resolution and CI validation fixes for the release.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[Configured content root] --> B[Resolve parent path]
    B --> C[Combine resolved parent and directory name]
    C --> D{Directory exists?}
    D -- No --> E[Return candidate path]
    D -- Yes --> F{Symbolic-link target?}
    F -- No --> E
    F -- Yes --> G[Resolve final link target]
    G --> B
    E --> H[Compare with resolved application directory]
Loading

Reviews (2): Last reviewed commit: "Update ContentRootValidator tests" | Re-trigger Greptile

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@codecov

codecov Bot commented Aug 10, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@661a2a2). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff            @@
##             main        #6   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?        19           
  Lines           ?       533           
  Branches        ?        67           
========================================
  Hits            ?       533           
  Misses          ?         0           
  Partials        ?         0           

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gimlichael
gimlichael merged commit ec6818e into main Aug 10, 2026
29 checks passed
@gimlichael
gimlichael deleted the v2.0.0/fix-main-ci-run branch August 10, 2026 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant