Fix CI pipeline and symlink resolution for 2.0.0 - #6
Merged
Conversation
- Enable macOS tests on pull_request events in CI workflow - Fix ContentRootValidator to recursively resolve chained symbolic links - Add comprehensive test coverage for symlink chains and root directory cases - Update README to clarify multi-OS CI behavior - Update CHANGELOG.md with fixes section This patch improves cross-platform symbolic link traversal and ensures complete test validation across all platforms during pull requests. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Greptile SummaryThe PR enables macOS validation for pull requests and recursively canonicalizes symbolic-link targets before content-root containment checks.
Confidence Score: 5/5The PR appears safe to merge because no blocking failure remains in the eligible follow-up review scope. No blocking failure remains. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Configured content root] --> B[Resolve parent path]
B --> C[Combine resolved parent and directory name]
C --> D{Directory exists?}
D -- No --> E[Return candidate path]
D -- Yes --> F{Symbolic-link target?}
F -- No --> E
F -- Yes --> G[Resolve final link target]
G --> B
E --> H[Compare with resolved application directory]
Reviews (2): Last reviewed commit: "Update ContentRootValidator tests" | Re-trigger Greptile |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 19
Lines ? 533
Branches ? 67
========================================
Hits ? 533
Misses ? 0
Partials ? 0 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch improves cross-platform symbolic link traversal and ensures complete test validation across all platforms during pull requests.