feat(settings): large adaptive modal + mobile sheet layout - #310
Merged
Conversation
…290 follow-up) - Modal 720x480 -> min(1080px, 92vw) x min(720px, 90vh): Maintenance\n lifecycle embed now renders fully without clipping\n- Narrow (<760px): full-bleed sheet + nav becomes horizontal scroll chips\n- CSS ordering fix: media block moved to end of style so it wins over the\n base .modal-body rule\n\nVerified live: desktop 1440 maintenance full render, mobile 375 full-bleed\n+ horizontal chips, 0 page errors. Note: 2 activity.test failures are\npre-existing date-flaky (Sundays), reproduced on clean develop.
🔍 Cora AI Code Review✅ No issues found. Code looks good! Review powered by cora-code · BYOK · MIT |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Settings dialog redesign per owner feedback ("dialog popup perlu lebih besar tapi tetap menyesuaikan width layout"):
720x480fixed →min(1080px, 92vw) × min(720px, 90vh/90dvh). The Maintenance tab (lifecycle embed) now renders fully without clipping..modal-bodyrule and lost the cascade — moved to the end of the style block (this is why the first mobile pass failed).Aligns with the uteke-mobile UX audit discipline (viewport-adaptive surfaces, no cramped dialogs).
Why
Settings lifecycle content was unreadable in the old 720x480 dialog, and mobile had no usable settings surface. This gives both a proper layout.
Testing
activity.test.tsfailures are pre-existing date-flaky (fail every Sunday), reproduced on clean develop without these changesRefs: #290 follow-up · Epic: #289