Improve call on HAL api : add get all ids

api/src/core/adapters/hal/HalAPI/index.ts

@@ -8,13 +8,16 @@ import { HAL } from "./types/HAL";
 
 const HAL_API_TIMEOUT = 60000;
 
+type HALID = Pick<HAL.API.Software, "docid">;
+
 export type HALAPIGateway = {
     software: {
         getById: (halDocid: string) => Promise<HAL.API.Software | undefined>;
         getAll: (params: {
             queryString?: string | undefined;
             SWHFilter?: boolean | undefined;
         }) => Promise<HAL.API.Software[]>;
+        getAllIds: (params: { queryString?: string | undefined; SWHFilter?: boolean | undefined }) => Promise<HALID[]>;
         getCodemetaByUrl: (urlSoftwareDoc: string) => Promise<HAL.SoftwareApplication | undefined>;
     };
     domain: {
@@ -115,6 +118,22 @@ export const makeHalAPIGateway = (source?: Source): HALAPIGateway => {
                 const json = await getHalApiRequest<HAL.API.Software>(url);
                 return json?.response?.docs ?? [];
             },
+            getAllIds: async (params: { queryString?: string; SWHFilter?: boolean }) => {
+                const { queryString, SWHFilter } = params;
+                let url = `https://api.archives-ouvertes.fr/search/?fq=docType_s:SOFTWARE&rows=10000&fl:docid`;
+
+                if (queryString) {
+                    url = url + `&q=${encodeURIComponent(queryString)}`;
+                }
+
+                // Filter only software who have an swhidId to filter clean data on https://hal.science, TODO remove and set it as an option to be generic
+                if (SWHFilter) {
+                    url = url + `&fq=swhidId_s:["" TO *]`;
+                }
+
+                const json = await getHalApiRequest<HAL.API.Software>(url);
+                return json?.response?.docs ?? [];
+            },
             getCodemetaByUrl: (urlSoftwareDoc: string) => {
                 const url = `${urlSoftwareDoc}/codemeta`;
                 return getHalRequest<HAL.SoftwareApplication>(url);

api/src/core/usecases/importFromSource.ts

@@ -63,7 +63,7 @@ const resolveAllIdsAccordingToSource = async (source: Source): Promise<string[]>
     switch (source.kind) {
         case "HAL":
             const halAPIGateway = makeHalAPIGateway(source);
-            return (await halAPIGateway.software.getAll({ SWHFilter: true })).map(doc => doc.docid);
+            return (await halAPIGateway.software.getAllIds({ SWHFilter: true })).map(doc => doc.docid);
         case "Zenodo":
             const zenodoAPI = makeZenodoApi(source);
             return (await zenodoAPI.records.getAllSoftware()).hits.hits.map(item => item.id.toString());