Skip to content

fix: make frankenphp-worker.php template idempotent on watcher restart#10191

Merged
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:frankenphp-worker-reentry
May 12, 2026
Merged

fix: make frankenphp-worker.php template idempotent on watcher restart#10191
paulbalandan merged 1 commit into
codeigniter4:developfrom
paulbalandan:frankenphp-worker-reentry

Conversation

@paulbalandan
Copy link
Copy Markdown
Member

Description
Trying to fix #9921 if it matters.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@paulbalandan paulbalandan added the bug Verified issues on the current code behavior or pull requests that will fix them label May 11, 2026
Copy link
Copy Markdown
Member

@michalsn michalsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't verify it because I couldn't reproduce the issue on my end.

But it makes sense.

@paulbalandan paulbalandan merged commit f5ad0cb into codeigniter4:develop May 12, 2026
5 checks passed
@paulbalandan paulbalandan deleted the frankenphp-worker-reentry branch May 12, 2026 06:57
@ddevsr
Copy link
Copy Markdown
Collaborator

ddevsr commented May 12, 2026

I will test soon, thanks @paulbalandan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Verified issues on the current code behavior or pull requests that will fix them

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bug: watcher in FrankenPHP mode worker after changes .env

4 participants