Skip to content

chore: Bump Rector to 2.5.3 and re-run it#10375

Merged
samsonasik merged 2 commits into
codeigniter4:developfrom
samsonasik:bump-rector-253
Jul 6, 2026
Merged

chore: Bump Rector to 2.5.3 and re-run it#10375
samsonasik merged 2 commits into
codeigniter4:developfrom
samsonasik:bump-rector-253

Conversation

@samsonasik

@samsonasik samsonasik commented Jul 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

This PR:

  • Bump Rector to 2.5.3
  • Re-run it to apply more on add return type on arrow functions
  • skip various new rules to be discussed later in separate PRs.

Checklist:

  • Securely signed commits
  • Component(s) with PHPDoc blocks, only if necessary or adds value (without duplication)
  • Unit testing, with >80% coverage
  • User guide updated
  • Conforms to style guide

@samsonasik

samsonasik commented Jul 5, 2026

Copy link
Copy Markdown
Member Author

Ready to merge 👍

@samsonasik samsonasik requested review from MGatner and ddevsr July 5, 2026 23:41
@samsonasik

samsonasik commented Jul 6, 2026

Copy link
Copy Markdown
Member Author

Thank you @ddevsr for the review.

Let's merge 👍

@samsonasik samsonasik merged commit d9ec94b into codeigniter4:develop Jul 6, 2026
56 checks passed
@samsonasik samsonasik deleted the bump-rector-253 branch July 6, 2026 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@michalsn michalsn Awaiting requested review from michalsn
@paulbalandan paulbalandan Awaiting requested review from paulbalandan
@MGatner MGatner Awaiting requested review from MGatner
1 more reviewer
@ddevsr ddevsr ddevsr approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@samsonasik @ddevsr