-
Notifications
You must be signed in to change notification settings - Fork 46
🤖 feat: support multiple workspace creation drafts #1918
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3bd9d089e7
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
@codex review Fixed orphaned draft placeholders when a section is deleted: drafts whose |
|
Codex Review: Didn't find any major issues. 👍 ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
Adds UI-only workspace creation drafts (placeholders) under projects so repeated "new workspace" clicks open independent drafts with per-draft persisted prompts via localStorage. --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `xhigh` • Cost: `$3.93`_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=xhigh costs=3.93 -->
- Stop prefixing newly-created workspaces with "[Draft]" (titles should be final after submit). - Key the creation ChatInput by pendingDraftId so switching drafts fully resets ephemeral UI state and avoids the "Creating workspace" overlay leaking into other drafts. --- _Generated with `mux` • Model: `openai:gpt-5.2` • Thinking: `high` • Cost: `$26.47`_ <!-- mux-attribution: model=openai:gpt-5.2 thinking=high costs=26.47 -->
a0d950f to
74a8ae7
Compare
Summary
Adds UI-only workspace draft placeholders so a single project can have multiple in-progress workspace creations at once.
Background
Previously, workspace creation persisted a single pending draft per project (a fixed localStorage scope). Clicking “New workspace” repeatedly just reopened the same draft.
Implementation
draftIddimension for/projectroutes.__draft__/${projectPath}/${draftId}and a persisted draft index (workspaceDraftsByProject).[Draft].Validation
make static-checkRisks
updateTitlefails (offline/older backend), a created workspace may keep the[Draft]prefix; user can rename manually.Generated with
mux• Model:openai:gpt-5.2• Thinking:xhigh• Cost:$20.37