Skip to content

Conversation

@matifali
Copy link
Member

  • Replace code-server with official VS Code CLI
  • Download CLI from code.visualstudio.com using cli-alpine-* URLs
  • Add release_channel variable (stable/insiders)
  • Add commit_id variable to pin specific VS Code versions
  • Support offline mode with fallback to code-server or cached vscode-server
  • Add comprehensive bun tests for settings, extensions, and CLI arguments
  • Add Terraform tests for variable validation

- Replace code-server with official VS Code CLI
- Download CLI from code.visualstudio.com using cli-alpine-* URLs
- Add release_channel variable (stable/insiders)
- Add commit_id variable to pin specific VS Code versions
- Support offline mode with fallback to code-server or cached vscode-server
- Add comprehensive bun tests for settings, extensions, and CLI arguments
- Add Terraform tests for variable validation
@matifali matifali requested a review from Copilot December 31, 2025 11:29
@matifali
Copy link
Member Author

@codex review

Copy link

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR refactors the vscode-web module to use the official VS Code CLI instead of code-server, enabling better version control and alignment with official VS Code tooling.

  • Migrates from code-server to official VS Code CLI with code serve-web command
  • Adds release_channel variable to support stable/insiders releases
  • Implements comprehensive offline mode with fallback to code-server or cached vscode-server
  • Adds extensive test coverage with 21 new integration tests

Reviewed changes

Copilot reviewed 5 out of 5 changed files in this pull request and generated 9 comments.

Show a summary per file
File Description
main.tf Removes platform variable, adds release_channel and repositions commit_id variable with updated description
run.sh Complete rewrite to download and use VS Code CLI instead of code-server, with offline fallback mechanisms
main.test.ts Adds comprehensive test suite with 21 tests covering script generation, settings management, extension installation, and container integration
vscode-web.tftest.hcl New Terraform validation tests for variable constraints and URL generation
README.md Updates documentation to reflect VS Code CLI usage and new configuration options

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant