Conversation
Signed-off-by: prathambatra <batrapratham999@gmail.com>
|
@jatinkatyal13 I have setup this. but on running npm lint I got lot of errors. I don't know much about prettier and linting. |
|
Are you getting errors for 'test' directory? because I have used semi colon and tabWidth = 4 in my PRs 😅 ( I realized it later :( ) |
|
That's what linting is for, yes it will have a lot of errors because the code wasn't written in a consistent manner. We should aim to have no linting errors ideally but code would function nonetheless |
|
what should i do now? all configs are fine? |
|
LGTM! |
|
travis CI build is failing |
@jatinkatyal13 |
|
back merge with the current Head and the test should not fail |
Signed-off-by: prathambatra batrapratham999@gmail.com
fixes #72