Skip to content

The css of the second should be better but i don't have time to play with it#2

Open
karamgaby wants to merge 5 commits into
coditechOld:masterfrom
karamgaby:master
Open

The css of the second should be better but i don't have time to play with it#2
karamgaby wants to merge 5 commits into
coditechOld:masterfrom
karamgaby:master

Conversation

@karamgaby
Copy link
Copy Markdown

No description provided.

@Xananax
Copy link
Copy Markdown
Contributor

Xananax commented May 20, 2017

Good catch on the solution being available :)

A few notes:

  1. There are many committed files that have nothing to do with the actual project, and are there for your workflow only (everything inside the .idea folder). Don't add those to your commits, they're just confusing and make me unable to accept the Pull Request
  2. There are many files, and I do not know which is what; You should name your files clearly; instead of style.css and styles.css, you should have style1.css and style2.css. Don't make me have to try them in the browser to know which is which. You also have stylem.css and stylesm.css. While I appreciate the minification effort (cool!), if you want to include those, then make their name similarly clear, a.k.a, style1.min.css as is the common convention, or style1-minified.css for even more clarity.
  3. You are currently keeping your content centered by using margin-right and margin-left. While not wrong per se, this does not allow for great control. How about setting a max-width value and setting margins to auto? You can then modify that max-width with media queries to fit different screen sizes.

You will find further correction commented on the lines of the files themselves.

Copy link
Copy Markdown
Contributor

@Xananax Xananax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are a few things to change in style.css. I haven't reviewed styles.css

Comment thread style/style.css
@@ -0,0 +1,269 @@
.fixed-contact {
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why adding a class? I agree it's better, but the exercise specified not touching the HTML :)

use #contact instead

Comment thread style/style.css
margin-right: 5px;
}

h3:after {
Copy link
Copy Markdown
Contributor

@Xananax Xananax May 20, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of h3::after, how about:

h3{
    border-bottom:2px solid red;
    padding-bottom:6px;
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants