Skip to content

feat(records): aggregate endpoint#2705

Draft
andersfylling wants to merge 8 commits into
masterfrom
andersfylling/records/aggregate-pr1
Draft

feat(records): aggregate endpoint#2705
andersfylling wants to merge 8 commits into
masterfrom
andersfylling/records/aggregate-pr1

Conversation

@andersfylling

@andersfylling andersfylling commented Jun 25, 2026

Copy link
Copy Markdown
Contributor

Description

Introduces support for the aggregate endpoint for the Records collection.

andersfylling and others added 2 commits June 25, 2026 10:49
Co-authored-by: Cursor <cursoragent@cursor.com>
Co-authored-by: Cursor <cursoragent@cursor.com>
@andersfylling andersfylling changed the title feat(records): add aggregate endpoint feat(records): aggregate endpoint Jun 30, 2026
andersfylling and others added 3 commits June 30, 2026 10:53
Resolve conflicts with filter/sync PRs (#2698, #2699). Reuse
TimeRange and RecordTargetUnits in the aggregate endpoint for
consistency with filter and sync.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…eneric base tests

Aggregate request builders raise NotImplementedError in _load and
result classes have non-standard constructors, so they cannot
participate in the generic dump/load round-trip tests.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
@codecov

codecov Bot commented Jun 30, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 98.36735% with 4 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.67%. Comparing base (d3e379a) to head (fb9c35e).

Files with missing lines Patch % Lines
...gnite/client/data_classes/data_modeling/records.py 97.76% 4 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           master    #2705    +/-   ##
========================================
  Coverage   93.67%   93.67%            
========================================
  Files         503      503            
  Lines       51030    51270   +240     
========================================
+ Hits        47802    48027   +225     
- Misses       3228     3243    +15     
Files with missing lines Coverage Δ
cognite/client/_api/data_modeling/records.py 97.50% <100.00%> (+0.48%) ⬆️
cognite/client/_sync_api/data_modeling/records.py 100.00% <100.00%> (ø)
...nite/client/data_classes/data_modeling/__init__.py 100.00% <ø> (ø)
...s_unit/test_api/test_data_modeling/test_records.py 100.00% <100.00%> (ø)
tests/tests_unit/test_base.py 98.94% <100.00%> (+<0.01%) ⬆️
...gnite/client/data_classes/data_modeling/records.py 97.89% <97.76%> (-0.18%) ⬇️

... and 5 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

andersfylling and others added 3 commits June 30, 2026 12:49
…aggregate classes from base tests

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…perty

Encapsulates the parsed bucket list behind a private attribute so callers
can't mutate cached state, and drops the redundant one-line docstrings
that only restated the class names.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant