Skip to content

feat: add P402 as Facilitator#996

Open
Z333Q wants to merge 1 commit intocoinbase:mainfrom
Z333Q:add-p402-router
Open

feat: add P402 as Facilitator#996
Z333Q wants to merge 1 commit intocoinbase:mainfrom
Z333Q:add-p402-router

Conversation

@Z333Q
Copy link

@Z333Q Z333Q commented Jan 20, 2026

Description

Tests

Checklist

  • I have formatted and linted my code
  • All new and existing tests pass
  • My commits are signed (required for merge) -- you may need to rebase if you initially pushed unsigned commits

@cb-heimdall
Copy link

cb-heimdall commented Jan 20, 2026

🟡 Heimdall Review Status

Requirement Status More Info
Reviews 🟡 0/1
Denominator calculation
Show calculation
1 if user is bot 0
1 if user is external 0
2 if repo is sensitive 0
From .codeflow.yml 1
Additional review requirements
Show calculation
Max 0
0
From CODEOWNERS 0
Global minimum 0
Max 1
1
1 if commit is unverified 0
Sum 1

@vercel
Copy link

vercel bot commented Jan 20, 2026

@Z333Q is attempting to deploy a commit to the Coinbase Team on Vercel.

A member of the Team first needs to authorize it.

@Z333Q Z333Q closed this Jan 20, 2026
@Z333Q Z333Q reopened this Jan 20, 2026
@phdargen
Copy link
Contributor

Hi @Z333Q, thanks for your submission!

  • please verify all your commits
  • files are in the wrong location, should go in typescript/site
  • are you sure facilitators is the correct category for your project? From your website it appears its primarily a client sdk? Please provide a valid facilitator url with working /supported endpoint

@phdargen phdargen self-assigned this Jan 20, 2026
@github-actions github-actions bot added the ecosystem Additions to ecosystem site label Jan 20, 2026
@Z333Q
Copy link
Author

Z333Q commented Jan 20, 2026

Thanks @phdargen! I have addressed all feedback:
File Locations: Fixed. metadata.json and the logo are now in typescript/site/app/....
Signature Verification: I have rebased and signed the commits.
Facilitator Category: Validated. We verify and settle logic on-chain (Base).
Verify Endpoint: https://www.p402.io/api/v1/facilitator/verify
Settle Endpoint: https://www.p402.io/api/v1/facilitator/settle

@Must-be-Ash Must-be-Ash self-assigned this Jan 20, 2026
@Must-be-Ash
Copy link
Contributor

Hi there! All commits must have verified signatures.
Screenshot 2026-01-20 at 12 15 02 PM
Screenshot 2026-01-20 at 12 15 32 PM

Copy link
Author

@Z333Q Z333Q left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

verify commit

@Must-be-Ash
Copy link
Contributor

Also /supported is still returning '404' and I tested the facilitator with an endpoint and it returned HTTP 200 but:

  • Uses ok field instead of success (x402 spec requires success: boolean)
  • Missing transaction field (required - must contain blockchain transaction hash)
  • Missing network field (required - must identify the blockchain network)
  • txHash is null, indicating no actual blockchain transaction occurred
  • Response explicitly indicates "demo mode" - not suitable for production

@Must-be-Ash
Copy link
Contributor

3c57c8c, a970adc, and 29f9b0b are still not signed
Screenshot 2026-01-20 at 12 39 17 PM
Screenshot 2026-01-20 at 12 39 26 PM

@Must-be-Ash
Copy link
Contributor

"verify": true,
"settle": true,
"supported": true,
"list": true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems there is no discovery endpoint live, please set list to false

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@phdargen done.
"list": false

@phdargen
Copy link
Contributor

phdargen commented Feb 1, 2026

Hi @Z333Q, tested your facilitator with this example on base mainnet: https://github.com/coinbase/x402/tree/main/examples/typescript/servers/express
but getting error: 'Failed to verify payment: 400 Bad Request'

Also your supported endpoint shows 0x0000000000000000000000000000000000000000 as signer, please fill in your actual facilitator address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ecosystem Additions to ecosystem site website

Development

Successfully merging this pull request may close these issues.

4 participants