Skip to content

perf(goleveldb): use LevelDB Has to skip value reads #288

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
songgaoye wants to merge 2 commits into
base: main
Choose a base branch
from
Open

perf(goleveldb): use LevelDB Has to skip value reads #288

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
df550b5
perf(goleveldb): use LevelDB Has to skip value reads
songgaoye Aug 27, 2026
a682ce8
fix rocksdb warnings
songgaoye Aug 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 3 additions & 4 deletions goleveldb.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,11 +57,10 @@ func (db *GoLevelDB) Get(key []byte) ([]byte, error) {

// Has implements DB.
func (db *GoLevelDB) Has(key []byte) (bool, error) {
bytes, err := db.Get(key)
if err != nil {
return false, err
if len(key) == 0 {
return false, errKeyEmpty
}
return bytes != nil, nil
return db.db.Has(key, nil)
}

// Set implements DB.
Expand Down
4 changes: 3 additions & 1 deletion tools/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,11 +9,13 @@ RUN apt update \
ARG ROCKSDB=9.8.4

# Install RocksDB
# GCC 12 reports false-positive uninitialized warnings from its AVX-512
# intrinsic headers while compiling RocksDB's bundled xxHash implementation.
RUN \
wget -q https://github.com/facebook/rocksdb/archive/refs/tags/v${ROCKSDB}.tar.gz \
&& tar -zxf v${ROCKSDB}.tar.gz \
&& cd rocksdb-${ROCKSDB} \
&& DEBUG_LEVEL=0 CXXFLAGS="-Wno-maybe-uninitialized" make -j4 shared_lib \
&& DEBUG_LEVEL=0 CXXFLAGS="-Wno-maybe-uninitialized -Wno-error=uninitialized" make -j4 shared_lib \
&& make install-shared \
&& ldconfig \
&& cd .. \
Expand Down
Loading