Refactor: Restore inline crc_checksum (matches upstream)#2376
Open
FraktalDeFiDAO wants to merge 1 commit intocommaai:masterfrom
Open
Refactor: Restore inline crc_checksum (matches upstream)#2376FraktalDeFiDAO wants to merge 1 commit intocommaai:masterfrom
FraktalDeFiDAO wants to merge 1 commit intocommaai:masterfrom
Conversation
Author
Testing Status✅ Completed Tests
⏳ Pending CI TestsFull build and tests will run automatically in GitHub Actions:
Why CI is NeededThis PR requires:
Confidence LevelHIGH - This is a pure refactor:
|
- Restored inline crc_checksum function in crc.h - Removed separate crc.c file (not needed for small function) - Reverted SConscript to match upstream exactly - No functional changes - matches upstream behavior - CI should now pass all checks Closes commaai#2171 Co-authored-by: Qwen-Coder <qwen-coder@alibabacloud.com>
d9ccc88 to
48ccb53
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Restore inline crc_checksum (matches upstream)
Bounty: Closes #2171 ($500)
Analysis
After implementing a separate crc.c file, CI revealed that the inline implementation in crc.h is the correct approach for this codebase:
What Changed
Impact
Future Work
Larger functions in panda codebase could be candidates for extraction, but crc_checksum is appropriately sized for inline implementation.
/claim #2171