[GSoC 2025] Setup: Debugger Headers & Out-of-Process Kernel#365
[GSoC 2025] Setup: Debugger Headers & Out-of-Process Kernel#365kr-2003 wants to merge 1 commit intocompiler-research:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #365 +/- ##
=======================================
Coverage 81.78% 81.78%
=======================================
Files 20 20
Lines 950 950
Branches 87 87
=======================================
Hits 777 777
Misses 173 173 🚀 New features to boost your workflow:
|
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| ************************************************************************************/ | ||
|
|
||
| #ifndef XEUS_CPP_DEBUGGER_HPP | ||
| #define XEUS_CPP_DEBUGGER_HPP |
There was a problem hiding this comment.
warning: header guard does not follow preferred style [llvm-header-guard]
| #define XEUS_CPP_DEBUGGER_HPP | |
| #ifndef XEUS_CPP_XDEBUGGER_HPP | |
| #define XEUS_CPP_XDEBUGGER_HPP |
|
|
||
| #include <map> | ||
| #include <mutex> | ||
| #include <set> |
There was a problem hiding this comment.
warning: included header mutex is not used directly [misc-include-cleaner]
| #include <set> | |
| #include <set> |
| #include <map> | ||
| #include <mutex> | ||
| #include <set> | ||
| #include <string> |
There was a problem hiding this comment.
warning: included header set is not used directly [misc-include-cleaner]
| #include <string> | |
| #include <string> |
| #include <string> | ||
|
|
||
| #include "nlohmann/json.hpp" | ||
| #include "xeus-cpp/xinterpreter.hpp" |
There was a problem hiding this comment.
warning: included header json.hpp is not used directly [misc-include-cleaner]
| #include "xeus-cpp/xinterpreter.hpp" | |
| #include "xeus-cpp/xinterpreter.hpp" |
| { | ||
| class xdebuglldb_client; | ||
|
|
||
| class XEUS_CPP_API debugger : public xeus::xdebugger_base |
There was a problem hiding this comment.
warning: class 'debugger' defines a destructor but does not define a copy constructor, a copy assignment operator, a move constructor or a move assignment operator [cppcoreguidelines-special-member-functions]
class XEUS_CPP_API debugger : public xeus::xdebugger_base
^| using base_type = xeus::xdebugger_base; | ||
|
|
||
| debugger( | ||
| xeus::xcontext& context, |
There was a problem hiding this comment.
warning: no header providing "xeus::xcontext" is directly included [misc-include-cleaner]
include/xeus-cpp/xdebugger.hpp:11:
- #ifdef __GNUC__
+ #include <xeus/xeus_context.hpp>
+ #ifdef __GNUC__|
|
||
| debugger( | ||
| xeus::xcontext& context, | ||
| const xeus::xconfiguration& config, |
There was a problem hiding this comment.
warning: no header providing "xeus::xconfiguration" is directly included [misc-include-cleaner]
include/xeus-cpp/xdebugger.hpp:11:
- #ifdef __GNUC__
+ #include <xeus/xkernel_configuration.hpp>
+ #ifdef __GNUC__| const xeus::xconfiguration& config, | ||
| const std::string& user_name, | ||
| const std::string& session_id, | ||
| const nl::json& debugger_config |
There was a problem hiding this comment.
warning: no header providing "nlohmann::json" is directly included [misc-include-cleaner]
include/xeus-cpp/xdebugger.hpp:11:
- #ifdef __GNUC__
+ #include <nlohmann/json_fwd.hpp>
+ #ifdef __GNUC__| const nl::json& debugger_config | ||
| ); | ||
|
|
||
| virtual ~debugger(); |
There was a problem hiding this comment.
warning: prefer using 'override' or (rarely) 'final' instead of 'virtual' [cppcoreguidelines-explicit-virtual-functions]
| virtual ~debugger(); | |
| ~debugger() override; |
| bool start() override; | ||
| void stop() override; | ||
| xeus::xdebugger_info get_debugger_info() const override; | ||
| virtual std::string get_cell_temporary_file(const std::string& code) const override; |
There was a problem hiding this comment.
warning: 'virtual' is redundant since the function is already declared 'override' [cppcoreguidelines-explicit-virtual-functions]
| virtual std::string get_cell_temporary_file(const std::string& code) const override; | |
| std::string get_cell_temporary_file(const std::string& code) const override; |
|
Hi @kr-2003, we have a CppInterOp release now. Could you please look at this? Or at least give me a list of PRs/branches in the order we will need to merge? |
3 participants
Description
This PR sets up debugger kernels that will use Out-Of-Process execution via CppInterOp. Also added basic header files required for debugger.
Type of change