Skip to content

Drop -march=native being a default flag when building xeus-cpp#443

Merged
mcbarton merged 1 commit intocompiler-research:mainfrom
mcbarton:Drop-march=native-flag-as-default-flag-when-building-xeus-cpp
Feb 11, 2026
Merged

Drop -march=native being a default flag when building xeus-cpp#443
mcbarton merged 1 commit intocompiler-research:mainfrom
mcbarton:Drop-march=native-flag-as-default-flag-when-building-xeus-cpp

Conversation

@mcbarton
Copy link
Collaborator

When building xeus-cpp -march=native shouldn't be a default flag, due to cases where xeus-cpp is cross compiled from one platform for a different platform. For example the osx 86 conda-forge package is built on a osx arm platform.

Copy link
Contributor

@vgvassilev vgvassilev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.25%. Comparing base (12c4570) to head (97c8d00).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #443   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files          21       21           
  Lines         864      864           
  Branches       78       78           
=======================================
  Hits          702      702           
  Misses        162      162           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton mcbarton merged commit 8bab1a5 into compiler-research:main Feb 11, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants