runtime/stdio: avoid hanging on console socket accept - #46
Open
jankaluza wants to merge 1 commit into
Open
Conversation
|
Caution The consumer version of Gemini Code Assist on GitHub has been sunset. All code review activity has officially ceased. |
Replace blocking `accept()` on `--console-socket` with polled waits that watch for runtime exit and enforce a 60s timeout. If the runtime exits after connecting, drain any queued connection before failing so a successfully delivered pty fd is not rejected. This fixes race found during the tests when conmon-v3 process blocked indefinitely during the tests. Signed-off-by: Jan Kaluza <jkaluza@redhat.com>
jankaluza
force-pushed
the
console-fd-blocks
branch
from
August 12, 2026 11:33
9abed5b to
c0bfbf4
Compare
|
Ephemeral COPR build failed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace blocking
accept()on--console-socketwith polled waits that watch for runtime exit and enforce a 60s timeout. If the runtime exits after connecting, drain any queued connection before failing so a successfully delivered pty fd is not rejected.This fixes race found during the tests when conmon-v3 process blocked indefinitely during the tests.