docs(MultiSelect): put the version badge under the heading, not after the prose - #700
Merged
Conversation
… the prose Every other section states the version before describing the feature; the chips section had the badge trailing the paragraph, so a reader learned it was new only after reading what it does. Also drops a stray leading space before the offcanvas badge. The one in the alerts list stays inline — there it marks a single bullet as new rather than the whole section, which is a different thing.
Coverage Report for CI Build 30960939096Coverage remained the same at 92.975%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Spotted by mrholek. The chips section had
<AddedIn version="6.0.0" />trailing its description:Every other section on the page — Global search two headings above, for instance — states the version first and then describes the feature. Trailing it means a reader finds out it is new only after reading what it does.
Rendered order confirmed on the built page: heading → "Added in v6.0.0" → prose.
Swept the rest of the docs for the same shape. Two other hits: