docs(migration): cover the changes the guide had missed - #712
Merged
Conversation
An audit of every v6-dev commit against the guide found five user-visible changes with no entry, and one entry that had gone stale. Missing: - **The `*.rtl.css` builds are gone** (#682). The biggest gap: 20 files left `dist/css` and nothing said so. Anyone linking `coreui.rtl.min.css` gets a 404 with no explanation of what to do instead. - **Button always exposes `aria-pressed`** (#706). - **Number Input** (#694) was mentioned only in passing, inside the entry about the frame it shares with Password Input, never announced as new. - **Multi Select option checkboxes are the form-check surface now** (#660, #661), which retires the per-indicator look variables. - **Markers are hidden with `list-style-type: ""`** (#664). Stale: the select-indicator entry still said "the RTL build flips the right/left keyword at compile time" — there is no RTL build. And the popup primitive entry claimed "the anchored presentation is unchanged", which stopped being true when the panel started fading in (#698).
Coverage Report for CI Build 31215126696Coverage decreased (-0.007%) to 92.982%Details
Uncovered ChangesNo uncovered changes found. Coverage Regressions1 previously-covered line in 1 file lost coverage.
Coverage Stats
💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I walked every commit on
v6-devsince the guide was written and checked it against the guide. Five user-visible changes had no entry, and two entries had gone stale.Missing
*.rtl.cssbuilds are gonedist/css—coreui.rtl.cssand friends, minified twins, maps, SRI hashes — and nothing said so. Anyone linkingcoreui.rtl.min.cssgets a 404 and no hint that they now drop the.rtland keepdir="rtl". Verified: no rtl files indist/css, no rtl scripts inpackage.json.aria-pressed[data-coreui-toggle="button"].number-input.jsdoes not exist in v5 at all.::beforepseudo-elements with their own variable set; the per-indicator look variables went with them (only$combobox-option-indicator-widthsurvives).list-style-type: ""replaceslist-style: nonelist-unstyledmixin.Stale
right/leftkeyword at compile time" — there is no RTL build. It comes from a[dir="rtl"]rule in the same sheet now.Checked and already covered
Browser floors (#697, #667), the picker rewrite and the
-dropdownrename (#666, #699),.form-control-groupand the per-family frames (#675, #693, #695, #696, #691), the combobox class unification (#656–#659), chip roles (#658), the utilities API changes (#684, #685), week/quarter masks (#673), Toast (#707), the promise API (#708), Collapse'stoggle(#710) and the reduced-motion gating (#705).Deliberately not added: pure bug fixes with no migration action — the Sidebar
dispose()fix (#687), Modal/Offcanvas focus restore (#663), the upstream EventHandler/Menu port (#662), the OTP autofill fixes (#665, #669) and the build fixes (#692).docs-buildcompletes with no broken links across 140 pages.