fix(live): edit_multi skips empty edits (no-op 500 hardening) - #2
Open
ljchang wants to merge 1 commit into
Open
Conversation
…op 500) edit_multi only skipped a slot when its edit was missing, not when present-but- empty (no expression/aus/blendshapes) — a no-op edit reached the renderer and hit _aus(None) -> 500. Skip empty edits too, matching the edit_frame_faces image path. pyfeat-live already avoids sending no-op edits (v0.8.19); this hardens the library so any caller is safe. To release in 0.1.2 (with the mouth-smoothing slider).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Defense-in-depth for the no-op-edit 500 (pyfeat-live v0.8.19 already avoids sending them frontend-side). edit_multi now skips a slot whose edit has no expression/aus/blendshapes, matching the edit_frame_faces image path. Hold for the 0.1.2 release (batch with the mouth-smoothing slider).