fix(installer): handle Docker Desktop disk probe fallback#4
Open
vladi-coti wants to merge 1 commit into
Open
Conversation
Use container root free-space as a fallback when DockerRootDir is reported logically but is not exposed on the host path, as happens on WSL with Docker Desktop.
Member
|
@vladi-coti can you please describe the scenario that this issue fixes? |
Member
Author
|
On WSL Docker Desktop, the installer’s 90 GB disk check looks at DockerRootDir on the host — but that path isn’t real there, so the check fails even when Docker has enough space. The fix falls back to df inside a short Alpine container (Docker’s actual disk). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use container root free-space as a fallback when DockerRootDir is reported logically but is not exposed on the host path, as happens on WSL with Docker Desktop.