Skip to content

[cfloat.syn], [cmath.syn] Add missing "// optional" comments for some macros #9254

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
eisenwave wants to merge 2 commits into
base: main
Choose a base branch
from
+7 −7
Open

[cfloat.syn], [cmath.syn] Add missing "// optional" comments for some macros #9254

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e88e02
[cfloat.syn] Add missing "// optional" comments for some macros
eisenwave Aug 13, 2026
f93786e
[cmath.syn] Add missing "// optional" comments for some macros
eisenwave Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions source/numerics.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9210,8 +9210,8 @@
#define @\libmacro{HUGE_VAL}@ @\seebelow@
#define @\libmacro{HUGE_VALF}@ @\seebelow@
#define @\libmacro{HUGE_VALL}@ @\seebelow@
#define @\libmacro{INFINITY}@ @\seebelow@
#define @\libmacro{NAN}@ @\seebelow@
#define @\libmacro{INFINITY}@ @\seebelow@ // optional
#define @\libmacro{NAN}@ @\seebelow@ // optional
#define @\libmacro{FP_INFINITE}@ @\seebelow@
#define @\libmacro{FP_NAN}@ @\seebelow@
#define @\libmacro{FP_NORMAL}@ @\seebelow@
Expand Down
10 changes: 5 additions & 5 deletions source/support.tex
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1830,11 +1830,11 @@
#define @\libmacro{FLT_ROUNDS}@ @\seebelow@
#define @\libmacro{FLT_EVAL_METHOD}@ @\seebelow@
#define @\libmacro{FLT_RADIX}@ @\seebelow@
#define @\libmacro{INFINITY}@ @\seebelow@
#define @\libmacro{NAN}@ @\seebelow@
#define @\libmacro{FLT_SNAN}@ @\seebelow@
#define @\libmacro{DBL_SNAN}@ @\seebelow@
#define @\libmacro{LDBL_SNAN}@ @\seebelow@
#define @\libmacro{INFINITY}@ @\seebelow@ // optional

@frederick-vs-ja frederick-vs-ja Aug 13, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also change [cmath.syn] for INFINITY and NAN. Also, we should indent these comments.

INFINITY was mandatory in the published C99/C11/C17, and then N2848 changed it to conditionally-supported. It seems that before N2848 INFINITY was required to be defined as something nonsense if the implementation doesn't support infinity.

I think WG14 N2848 should be treated as DR, but I'm nor sure whether we should add some entry to Annex C.

@eisenwave eisenwave Aug 14, 2026 •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added the changes to [cmath.syn]. If this is basically a DR, then I don't see a need for an Annex C entry. We have always had the same contents as the C header, and the C header just got some bug-fixes, so it's not really like something changed in C++.

Comment thread
eisenwave marked this conversation as resolved.
#define @\libmacro{NAN}@ @\seebelow@ // optional
#define @\libmacro{FLT_SNAN}@ @\seebelow@ // optional
#define @\libmacro{DBL_SNAN}@ @\seebelow@ // optional
#define @\libmacro{LDBL_SNAN}@ @\seebelow@ // optional
#define @\libmacro{FLT_MANT_DIG}@ @\seebelow@
#define @\libmacro{DBL_MANT_DIG}@ @\seebelow@
#define @\libmacro{LDBL_MANT_DIG}@ @\seebelow@
Expand Down
Loading