Update spec tests based on 2025-10-08 cql-tests source#353
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #353 +/- ##
=======================================
Coverage 87.58% 87.58%
=======================================
Files 52 52
Lines 4607 4607
Branches 1297 1297
=======================================
Hits 4035 4035
Misses 359 359
Partials 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
7d4cd37 to
e1fc9b5
Compare
Some of the spec-data tests are skipped because the compiler translates them wrong and/or because the listed expected output is incorrect. When these issues are resolved, the tests can be unskipped -- but it can be arduous to check all the tests to see which ones can be unskipped. Adding a script that can do this for us.
79fc78f to
4b7363d
Compare
hossenlopp
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update the specification tests based on the latest source at https://github.com/cqframework/cql-tests. This required skipping a set of new tests based on an overload of Expand that takes a single interval as the first argument.
NEW: This now includes a new
check-skip-listscript that will run through the skip-list.txt file and try enabling each tests again to see if it still fails. If it no longer fails, it will remove it from the skip list. Run it usingnpm run check-skip-list.This PR now also removes some spec tests from the skip list that are now passing.
Submitter:
npm run test:plusto run tests, lint, and prettier)cql4browsers.jsbuilt withnpm run build:browserifyif source changed.Reviewer:
Name: