Skip to content

Update spec tests based on 2025-10-08 cql-tests source#353

Merged
cmoesel merged 4 commits intomasterfrom
cql-tests-update-20251008
Feb 26, 2026
Merged

Update spec tests based on 2025-10-08 cql-tests source#353
cmoesel merged 4 commits intomasterfrom
cql-tests-update-20251008

Conversation

@cmoesel
Copy link
Member

@cmoesel cmoesel commented Oct 8, 2025

Update the specification tests based on the latest source at https://github.com/cqframework/cql-tests. This required skipping a set of new tests based on an overload of Expand that takes a single interval as the first argument.

NEW: This now includes a new check-skip-list script that will run through the skip-list.txt file and try enabling each tests again to see if it still fails. If it no longer fails, it will remove it from the skip list. Run it using npm run check-skip-list.

This PR now also removes some spec tests from the skip list that are now passing.

Submitter:

  • This pull request describes why these changes were made
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • Tests are included and test edge cases
  • Tests have been run locally and pass
  • Code coverage has not gone down and all code touched or added is covered.
  • [n/a] Code passes lint and prettier (hint: use npm run test:plus to run tests, lint, and prettier)
  • [n/a] All dependent libraries are appropriately updated or have a corresponding PR related to this change
  • [n/a] cql4browsers.js built with npm run build:browserify if source changed.

Reviewer:

Name:

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@codecov-commenter
Copy link

codecov-commenter commented Oct 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.58%. Comparing base (51df256) to head (4b7363d).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #353   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files          52       52           
  Lines        4607     4607           
  Branches     1297     1297           
=======================================
  Hits         4035     4035           
  Misses        359      359           
  Partials      213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@cmoesel cmoesel force-pushed the cql-tests-update-20251008 branch from 7d4cd37 to e1fc9b5 Compare February 26, 2026 12:57
Some of the spec-data tests are skipped because the compiler translates them wrong and/or because the listed expected output is incorrect. When these issues are resolved, the tests can be unskipped -- but it can be arduous to check all the tests to see which ones can be unskipped. Adding a script that can do this for us.
@cmoesel cmoesel force-pushed the cql-tests-update-20251008 branch from 79fc78f to 4b7363d Compare February 26, 2026 20:44
Copy link
Contributor

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Nice script for checking the skipped list.

@cmoesel cmoesel merged commit 1545ebb into master Feb 26, 2026
6 of 8 checks passed
@cmoesel cmoesel deleted the cql-tests-update-20251008 branch February 26, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants