Merged
Conversation
- Update simple model to add relationships from Conditions to Encounters - Update simple model to add Medication record type - Update tests to use relationship clauses that use real relationships - Update tests to test relationships with empty secondary sources
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #354 +/- ##
=======================================
Coverage 87.55% 87.55%
=======================================
Files 52 52
Lines 4596 4596
Branches 1295 1295
=======================================
Hits 4024 4024
Misses 359 359
Partials 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
hossenlopp
approved these changes
Dec 2, 2025
Contributor
hossenlopp
left a comment
There was a problem hiding this comment.
Good catch! This should help us avoid mistakes during future updates. I skipped running this through fqm-e since no changes in compiled output.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the model and query relationship tests to better reflect real relationship queries. It also tests behavior with empty secondary sources as described in FHIR-53144.
These changes include:
Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.
Submitter:
npm run test:plusto run tests, lint, and prettier)cql4browsers.jsbuilt withnpm run build:browserifyif source changed.Reviewer:
Name: