Conversation
Starting w/ version 4.1.8, ucum-lhc is strict when validating UCUM units. Accoring to the UCUM spec, only ASCII characters 33 - 126 are allowed within curly braces. Some of our tests had spaces within the brackets, so those have been fixed. See: https://ucum.org/ucum
Resolve audit issues that are possible to resolve. Remaining issues have no fix available.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #356 +/- ##
==========================================
+ Coverage 87.55% 87.58% +0.02%
==========================================
Files 52 52
Lines 4596 4607 +11
Branches 1295 1297 +2
==========================================
+ Hits 4024 4035 +11
Misses 359 359
Partials 213 213 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Note that the Also note that although Codecov says 4 lines in my changes are missing coverage, I could only find one line in the report -- and it wasn't new; it was a constructor that used to be all on one line but prettier split it across three. So it doesn't actually represent new or changed code at all. |
hossenlopp
left a comment
There was a problem hiding this comment.
Looks good and has a completely clean regression run in fqm-e.
| should.not.exist(date[field]); | ||
| } | ||
| date.isDate.should.equal.true; | ||
| date.isDate.should.equal(true); |
There was a problem hiding this comment.
Good catch on all of these. They weren't actually doing the assertion before...
There was a problem hiding this comment.
Thanks. Although chances are pretty good that I'm the one who made the mistakes in the first place!
|
Force-merging this since the npm audit issues are currently not resolvable. |
This PR updates dependency libraries to their latest versions. It also addresses
npm auditreported vulnerabilities to the extent possible. Note, however, that some vulnerabilities currently have no available patch releases.Note that some updated dependencies required corresponding changes to code and/or tests:
eslint: needed to update eslint config and fix new eslint violationsprettier: needed to fix new prettier violationstypescript: needed to fix new typescript compiler violationsluxon: needed to updatefromObjectcalls to use new function signature@lhncbc/ucum-lhc: needed to update or skip tests that used custom UCUM units with spacesTo test: Verify that all tests continue to pass and ensure the library works as it did before. Note that since
@lhncbc/ucum-lhcnow throws when custom units contain invalid characters, we might see "regressions" when executing CQL that uses invalid custom UCUM units.Submitter:
npm run test:plusto run tests, lint, and prettier)cql4browsers.jsbuilt withnpm run build:browserifyif source changed.Reviewer:
Name: @hossenlopp