Skip to content

Upgrade Translator to v4.2#357

Merged
cmoesel merged 3 commits intomasterfrom
translator-4-take2
Feb 26, 2026
Merged

Upgrade Translator to v4.2#357
cmoesel merged 3 commits intomasterfrom
translator-4-take2

Conversation

@cmoesel
Copy link
Member

@cmoesel cmoesel commented Feb 24, 2026

This PR updates the CQL-to-ELM translator to use version 4.2.0 (the version expected to be adopted by MADiE soon). Updating the translator does not affect execution, but it affects all of our unit tests that are translated from CQL. Upgrading to 4.2.0 allows us to confirm that execution still works correctly on ELM JSON that is produced from the 4.2.0 translator.

Note that the translator upgrade was fairly significant since CQL-to-ELM 4.2.0 is now a Kotlin project. In addition, Java 17 and Gradle 9 are now needed to run the translation tasks.

Submitter:

  • This pull request describes why these changes were made
  • Code diff has been done and been reviewed (it does not contain: additional white space, not applicable code changes, debug statements, etc.)
  • [n/a] Tests are included and test edge cases
  • Tests have been run locally and pass
  • [n/a] Code coverage has not gone down and all code touched or added is covered.
  • [n/a] Code passes lint and prettier (hint: use npm run test:plus to run tests, lint, and prettier)
  • All dependent libraries are appropriately updated or have a corresponding PR related to this change
  • [n/a] cql4browsers.js built with npm run build:browserify if source changed.

Reviewer:

Name: @hossenlopp

  • Code is maintainable and reusable, reuses existing code and infrastructure where appropriate, and accomplishes the task’s purpose
  • The tests appropriately test the new code, including edge cases
  • You have tried to break the code

@cmoesel
Copy link
Member Author

cmoesel commented Feb 24, 2026

NOTE: npm audit is expected to fail as it is reporting vulnerabilities that currently cannot be fixed.

@hossenlopp hossenlopp self-requested a review February 24, 2026 19:55
Copy link
Contributor

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but the spec-tests built output no longer being pretty printed could be a minor annoyance for future debugging.

@cmoesel
Copy link
Member Author

cmoesel commented Feb 24, 2026

Good point about the spec-tests. I'll look at the CLI to see if there is an option for pretty print. If not, I'll consider adding it as a post-process after generating the spec-tests ELM JSON.

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.58%. Comparing base (6aa1de6) to head (46607c4).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #357   +/-   ##
=======================================
  Coverage   87.58%   87.58%           
=======================================
  Files          52       52           
  Lines        4607     4607           
  Branches     1297     1297           
=======================================
  Hits         4035     4035           
  Misses        359      359           
  Partials      213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Contributor

@hossenlopp hossenlopp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prettified spec tests are good. 👍

@cmoesel cmoesel merged commit 51df256 into master Feb 26, 2026
6 of 8 checks passed
@cmoesel cmoesel deleted the translator-4-take2 branch February 26, 2026 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants