Add Windows ConPTY support#208
Closed
TerryHowe wants to merge 3 commits into
Closed
Conversation
This adds full Windows support using ConPTY (Windows Pseudo Console API). Key changes include: - New Pty and Tty interfaces to abstract Unix *os.File and Windows handles - Windows-specific implementation using ConPTY API - Updated API to return interfaces instead of concrete *os.File types - Cross-platform window size management - Process lifecycle management for Windows - Updated golangci-lint configuration to version 2 format - Modernized Go version support (1.21.5) Co-Authored-By: Nathan Rijksen <nathanr@activestate.com> Co-Authored-By: photostorm <eephoto45@gmail.com> Co-Authored-By: Larry Clapp <larry@theclapp.org> Co-Authored-By: Guillaume J. Charmes <git+guillaume@charmes.net>
|
Have you had a chance to find the mistake I had in the code where we're getting an invalid handler when we're trying to set the size because I haven't had the time to actually look into the issue fully? I think it's just a simple mistake I have somewhere. |
Author
|
Converted to draft for now, I need to fix somethings according to my testing. |
|
Nice!! Thank you for taking the time to work on this |
Author
|
There are other projects that have windows support |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds full Windows support using ConPTY (Windows Pseudo Console API). Key changes include:
I have rebased and squashed the commits to one commit and listed the other authors as co-authors. This will make future rebases easier.
Closes: #161
Closes: #95
Closes: #155