-
-
Notifications
You must be signed in to change notification settings - Fork 70
Add a completion function. #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Please check this. The target branch is creativecommons:main. |
Did you test your changes?
|
scripts/1-fetch/wikipedia_fetch.py
Outdated
| try: | ||
| with open(FILE_LANGUAGES, "r", newline="") as file_obj: | ||
| reader = csv.DictReader(file_obj, dialect="unix") | ||
| if len(list(reader)) > 0: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To ensure this tests more than the header please increase the required lines (maybe to 300).
TimidRobot
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking good, almost there
Fixes
Description
I added a check_completion funtion for wikipedia_fetch.py and removed commented lines from github fetch.py
Checklist
Update index.md).mainormaster).visible errors.
Developer Certificate of Origin
For the purposes of this DCO, "license" is equivalent to "license or public domain dedication," and "open source license" is equivalent to "open content license or public domain dedication."
Developer Certificate of Origin