fix(rpc): Missing boundary check in GetTransactionReceipt#861
fix(rpc): Missing boundary check in GetTransactionReceipt#861JayT106 wants to merge 4 commits intocrypto-org-chain:developfrom
Conversation
This comment has been minimized.
This comment has been minimized.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #861 +/- ##
===========================================
- Coverage 40.69% 40.66% -0.04%
===========================================
Files 190 190
Lines 15452 15471 +19
===========================================
+ Hits 6288 6291 +3
- Misses 8491 8499 +8
- Partials 673 681 +8
🚀 New features to boost your workflow:
|
|
I think we should also check other code in |
| return nil, nil | ||
| } | ||
| } | ||
| if int(res.TxIndex) >= len(resBlock.Block.Txs) { |
There was a problem hiding this comment.
Do you know in which scenario this is possible?
There was a problem hiding this comment.
Theoretically it shouldn't happen. It just a defensive coding.
check added. |
Closes: #XXX
Description
For contributor use:
docs/) or specification (x/<module>/spec/)godoccomments.Unreleasedsection inCHANGELOG.mdFiles changedin the Github PR explorerFor admin use:
WIP,R4R,docs, etc)