fix(history-index): normalize Unix stat metadata on macOS - #355
Open
createsomethingtoday wants to merge 1 commit into
Open
fix(history-index): normalize Unix stat metadata on macOS#355createsomethingtoday wants to merge 1 commit into
createsomethingtoday wants to merge 1 commit into
Conversation
createsomethingtoday
marked this pull request as draft
August 8, 2026 04:30
createsomethingtoday
marked this pull request as ready for review
August 8, 2026 14:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Normalize
libc::statdevice and mode fields at the history-index clone identity boundary so current main compiles on macOS ARM64.macOS exposes
st_dev,st_mode, andS_IF*with narrower integer types than Linux.FileIdentityintentionally stores normalizedu64/u32values, so this performs explicit checked/widening conversions at capture and comparison sites without changing identity semantics.Validation
//crates/ctx-history-refresh:unit_tests: compile failure with 14 type mismatches in this file.6153be7816bdab7da7b5e650750b87ee55065634://crates/ctx-history-refresh:unit_tests: compiles, 152/154 pass.//crates/ctx-history-index:unit_tests: compiles, 338/340 pass.//crates/ctx-cli:search_refresh_tests: 20/21 pass.git diff --check: pass.The residual failures are current-main macOS filesystem, route-authority, and passive-watcher assertions; this PR does not weaken or suppress them.