Fix BeamFrequencySelector drift on changes#2792
Merged
daid merged 3 commits intodaid:masterfrom Mar 15, 2026
Merged
Conversation
Update the selected index on BeamFrequencySelector when the beam frequency changes elsewhere, for instance on another crew screen or via Lua.
When pressing the beam frequency decrease keybind, the selector callback isn't run, so the frequency command isn't actually sent to the server despite the selector's value changing. This leads to perceived drift between the client and server. This doesn't affect mouse selection or changing of the selector, only changes via keybind. Run the callback when the keybind is pressed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix client/server drift in
BeamFrequencySelector.When the beam frequency changes elsewhere, for instance on another crew screen or via Lua, update the selector.
Before:
Screencast_20260314_213430.webm
setSelectionIndexfrom init toonUpdate.When the server's beam/shield frequency setting is changed mid-game, update the control on connected clients.
Before:
Screencast_20260314_213601.webm
gameGlobalInfo->use_beam_shield_frequenciescheck from init toonUpdate.When the beam frequency is decreased via keybind, send the frequency change command to the server.
Before:
Screencast_20260314_113357.webm