Add missing domain error types to REST API error handling middleware#65
Closed
Copilot wants to merge 2 commits into
Closed
Add missing domain error types to REST API error handling middleware#65Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
Copilot
AI
changed the title
[WIP] Fix issues in refactoring to use neverthrow Result types
Add missing domain error types to REST API error handling middleware
Feb 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The REST API error handling middleware was missing several domain error types that were already properly handled by the oRPC layer. This caused these errors to be treated as generic 500 errors instead of their correct HTTP status codes when thrown from REST endpoints.
Changes
ScoreTypeMismatchErrorandTooManyParticipantsErrorHeatDomainErrorunion: AddedScoreNotFoundErrorandScoreTypeMismatchErrorisHeatDomainErrorguard: Added instanceof checks for the new heat error typesBracketDomainErrorunion: AddedTooManyParticipantsErrorisBracketDomainErrorguard: Added instanceof check for the new bracket error typeImpact
Errors are now correctly mapped to HTTP status codes:
ScoreNotFoundError→ 404 (was 500)ScoreTypeMismatchError→ 400 (was 500)TooManyParticipantsError→ 400 (was 500)REST API error handling now matches oRPC error behavior.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.