Validate destination heat existence before advancing riders#67
Merged
Conversation
Copilot
AI
changed the title
[WIP] Update error handling to use Result types instead of exceptions
Validate destination heat existence before advancing riders
Feb 3, 2026
danbim
approved these changes
Feb 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses code review feedback from #62 requesting explicit validation of destination heats before advancing riders. Previously,
addRiderToHeatsilently returned when a destination heat didn't exist, masking potential data corruption bugs.Changes
heat-service.ts: Extract
validateAndAddRiderToHeat()private method that checks destination heat exists viagetHeatByHeatId()before callingaddRiderToHeat(). Returnserr(HeatDoesNotExistError)on missing heat.bracket-service.ts: Modify
completeByeHeat()to returnResult<void, HeatDoesNotExistError>, add destination heat validation, propagate errors to caller. AddHeatDoesNotExistErrortoBracketServiceErrorunion.Example
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.