Skip to content

Change to workflowconfig json attribute name#1821

Merged
nfahlgren merged 16 commits intov5.0from
output-key-name
Jan 30, 2026
Merged

Change to workflowconfig json attribute name#1821
nfahlgren merged 16 commits intov5.0from
output-key-name

Conversation

@joshqsumner
Copy link
Copy Markdown
Contributor

@joshqsumner joshqsumner commented Oct 21, 2025

Describe your changes
Changing the workflowconfig.json attribute name to workflowconfig.results for reasons listed in #1820 .

Type of update
This is a feature update/docs change.

Associated issues
Closes #1820

Additional context
This makes WorkflowConfig and jupyterconfig more consistent.

For the reviewer
See this page for instructions on how to review the pull request.

  • PR functionality reviewed in a Jupyter Notebook
  • All tests pass
  • Test coverage remains 100%
  • Documentation tested
  • New documentation pages added to plantcv/mkdocs.yml
  • Changes to function input/output signatures added to updating.md
  • Code reviewed
  • PR approved

@joshqsumner joshqsumner added work in progress Mark work in progress update Updates an existing feature/method merge in order Set of PRs that need to be merged sequentially good first issue/PR Suitable for a first time contributor/reviewer labels Oct 21, 2025
@deepsource-io
Copy link
Copy Markdown

deepsource-io Bot commented Oct 21, 2025

Here's the code health analysis summary for commits 286864c..bf9116f. View details on DeepSource ↗.

Analysis Summary

AnalyzerStatusSummaryLink
DeepSource Python LogoPython✅ SuccessView Check ↗
DeepSource Test coverage LogoTest coverage✅ SuccessView Check ↗

Code Coverage Report

MetricAggregatePython
Branch Coverage100%100%
Composite Coverage100%100%
Line Coverage100%100%
New Branch Coverage100%100%
New Composite Coverage100%100%
New Line Coverage100%, ✅ Above Threshold100%, ✅ Above Threshold

💡 If you’re a repository administrator, you can configure the quality gates from the settings.

@joshqsumner joshqsumner added ready to review and removed work in progress Mark work in progress labels Oct 21, 2025
@joshqsumner joshqsumner added this to the PlantCV v5.0 milestone Oct 24, 2025
@nfahlgren nfahlgren merged commit 6fc49b7 into v5.0 Jan 30, 2026
5 checks passed
@nfahlgren nfahlgren deleted the output-key-name branch January 30, 2026 22:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

good first issue/PR Suitable for a first time contributor/reviewer merge in order Set of PRs that need to be merged sequentially ready to review update Updates an existing feature/method

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants