fix(migrate-approve): interpolate the project slug, not the literal placeholder - #1935
Closed
jbmml wants to merge 1 commit into
Closed
fix(migrate-approve): interpolate the project slug, not the literal placeholder#1935jbmml wants to merge 1 commit into
jbmml wants to merge 1 commit into
Conversation
…laceholder
The memory/feedback branch returned join(HOME, '.claude', 'projects',
'${HARNESS_USER_DIR}', 'memory') — the ${...} sits in a plain double-quoted
string and is never interpolated, so the path names a directory literally called
${HARNESS_USER_DIR} and can never match a real session dir. Derive the slug the
way SessionHarvester.ts does. NOTE: which cwd's slug is intended isn't certain
from outside the codebase — flagging for confirmation. Refs danielmiessler#1932.
Owner
|
Ported with credit, adapted: the slug is derived from the config root (getClaudeDir) so it follows CLAUDE_CONFIG_DIR, and the principal-specific literal is gone from the shipped file. Closing, next release. Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refs #1932. Opened as draft — the fix direction is right but the intended slug source needs a maintainer call (see below).
The
memory/feedbackbranch returnedjoin(HOME, '.claude', 'projects', '${HARNESS_USER_DIR}', 'memory')— the${...}sits in a plain double-quoted string and is never interpolated, so the path names a directory literally called${HARNESS_USER_DIR}and can never match a real session dir.This patch derives the slug the way
SessionHarvester.tsdoes (CLAUDE_DIRpath slugified). Open question:SessionHarvesterslugifies~/.claudeitself; if the feedback path should key off a different cwd, the slug source should change accordingly. Happy to adjust once you confirm the intended value — the issue (#1932) has the full context.