Added improved websocket handling with new WebSocketApp implementation#146
Closed
bfolkens wants to merge 1 commit intodanpaquin:masterfrom
Closed
Added improved websocket handling with new WebSocketApp implementation#146bfolkens wants to merge 1 commit intodanpaquin:masterfrom
bfolkens wants to merge 1 commit intodanpaquin:masterfrom
Conversation
Owner
|
This is nice to have, but the true problems with the websocket/orderbook are being addressed in #166 so I will eave this open as a reminder until 166 is complete. Thank you so much for your support! |
datafireball
approved these changes
Dec 9, 2017
datafireball
left a comment
datafireball
left a comment
There was a problem hiding this comment.
works well and backward compatible
Owner
|
This will need to be revisited due to other, higher priority changes that have been made. Thank you for the contribution! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Switch over to the new WebSocketApp implementation, courtesy of @endtwist fork.