[+] WebsocketClient thread naming#351
Open
nazariyv wants to merge 3 commits intodanpaquin:masterfrom
nazariyv:master
Open
[+] WebsocketClient thread naming#351nazariyv wants to merge 3 commits intodanpaquin:masterfrom nazariyv:master
nazariyv wants to merge 3 commits intodanpaquin:masterfrom
nazariyv:master
Conversation
nazariyv
commented
Jan 26, 2019
nazariyv
commented
- Added kwarg for the name of the main thread of WSC
- Added kwarg for the keepalive thread name
1. Added kwarg in the constructor of the WSC to name the thread on which it runs 2. Added kwarfg for the keepalive thread.
[+] WebSocketClient thread naming
|
This will be really useful for debugging |
TristanJM
approved these changes
Jan 26, 2019
Author
|
Hey, can we merge this, please? |
mcardillo55
requested changes
Oct 27, 2020
Collaborator
mcardillo55
left a comment
mcardillo55
left a comment
There was a problem hiding this comment.
Hi! I like the idea for logging/debugging purposes, but I noticed a couple syntax issues. Thanks!
| self.on_open() | ||
| self.thread = Thread(target=_go) | ||
| self.keepalive = Thread(target=self._keepalive) | ||
| self.thread = Thread(target=_go, name=thread_name) |
Collaborator
There was a problem hiding this comment.
Should reference self.thread_name instead.
| self.thread = Thread(target=_go) | ||
| self.keepalive = Thread(target=self._keepalive) | ||
| self.thread = Thread(target=_go, name=thread_name) | ||
| self.keepalive = Thread(target=self._keepalive, name=keeaplive_thread_name) |
Collaborator
There was a problem hiding this comment.
Should reference self.keepalive_thread_name. Also there is a typo in "keepalive"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.