DAOS-15518 control: Fix dmg network scan for UCX. by jgmoore-or · Pull Request #17636 · daos-stack/daos

jgmoore-or · 2026-03-03T20:31:35Z

Test-provider: ucx+dc_x
Skip-func-hw-test-medium-verbs-provider: true
Allow-unstable-test: true

Steps for the author:

Commit message follows the guidelines.
Appropriate Features or Test-tag pragmas were used.
Appropriate Functional Test Stages were run.
At least two positive code reviews including at least one code owner from each category referenced in the PR.
Testing is complete. If necessary, forced-landing label added and a reason added in a comment.

After all prior steps are complete:

Gatekeeper requested (daos-gatekeeper added as a reviewer).

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

github-actions · 2026-03-03T20:32:04Z

Errors are Unable to load ticket data
https://daosio.atlassian.net/browse/DAOS-15518

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

daosbuild3 · 2026-03-03T23:15:01Z

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17636/11/testReport/

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

daosbuild3 · 2026-03-04T00:10:22Z

Test stage Unit Test on EL 8.8 completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17636/12/testReport/

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

daosbuild3 · 2026-03-04T04:15:18Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17636/13/execution/node/1074/log

daosbuild3 · 2026-03-04T16:06:43Z

Test stage Functional on EL 8.8 completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17636/14/execution/node/1073/log

daosbuild3 · 2026-03-04T18:20:34Z

Test stage Functional Hardware Medium completed with status FAILURE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net//job/daos-stack/job/daos/view/change-requests/job/PR-17636/14/execution/node/1357/log

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

daosbuild3 · 2026-03-22T18:06:10Z

Test stage Functional Hardware Medium MD on SSD completed with status UNSTABLE. https://jenkins-3.daos.hpc.amslabs.hpecorp.net/job/daos-stack/job/daos//view/change-requests/job/PR-17636/25/testReport/

kjacque

Control plane stuff LGTM. I think the Python test changes need to be clarified a bit... really tough to read and understand.

kjacque · 2026-04-02T22:57:11Z

src/control/lib/hardware/cart/cart.go

@@ -1,5 +1,6 @@
 //
 // (C) Copyright 2024 Intel Corporation.
+// (C) Copyright 2025-2026 Hewlett Packard Enterprise Development LP


Looks like this copyright line got added automatically though nothing else is changed in the file.

I will remove this changed file from the PR.

kjacque · 2026-04-02T23:04:50Z

src/tests/ftest/control/dmg_network_scan.py

-            if server_provider == entry.provider:
+            if (server_provider == entry.provider or server_provider[0:3] == "ucx"
+                    and server_provider[0:6] == entry.provider[0:6]):
                entry.device = None
                sys_info.append(entry)
+            if server_provider[0:3] == "ucx" and server_provider[0:6] == entry.provider[0:6]:
+                dup_entry = copy.deepcopy(entry)
+                dup_entry.provider = re.sub(r"mlx[0-9]+", "x", dup_entry.provider)
+                sys_info.append(dup_entry)
+                dup_entry2 = copy.deepcopy(entry)
+                dup_entry2.provider = entry.provider[0:6]
+                sys_info.append(dup_entry2)


I find this really hard to understand as a reader... I believe you that it works, but @daos-stack/ftest-owners should weigh in on how to make this test implementation better.

The changed test verification has to add two additional entries to what the test code that looks at ucx_info output comes up with (to match up with "provider:" value in server.yml). The changed code does a couple of deep copy duplicates entries of the existing entries on the sys_info list, and modify the dups to augment the list with the other synonym variants.

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg_network_scan for UCX.

d2ff421

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

jgmoore-or requested review from a team as code owners March 3, 2026 20:31

jgmoore-or marked this pull request as draft March 3, 2026 20:32

jgmoore-or added 7 commits March 3, 2026 20:42

DAOS-15518 control: Fix dmg network scan for UCX.

8bd5a02

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

ba8f266

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

a0b599f

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

5ec135a

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

886ecc7

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

6713dc3

Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for ucx.

6f15d09

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dng network scan for UCX.

c57707b

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

ed77ad9

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

jgmoore-or added 9 commits March 19, 2026 21:09

DAOS-15518 control: Fix dmg network scan for UCX.

741ca3f

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

dd0a0d9

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

dac9c88

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

e83d91a

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

dd1592e

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

7378be5

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS- 15518 control: Fix dmg network scan for UCX.

2f8ea11

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

DAOS-15518 control: Fix dmg network scan for UCX.

23ad777

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

Merge branch 'master' into jgm/DAOS-15518

f3726bd

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true

DAOS015518 control: Fix dmg network scan for UCX.

9b1d2e4

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

jgmoore-or changed the title ~~DAOS-15518 control: Fix dmg_network_scan for UCX.~~ DAOS-15518 control: Fix dmg network scan for UCX. Mar 23, 2026

jgmoore-or mentioned this pull request Apr 1, 2026

DAOS-18710 test: Update provider tests to use dc_x for UCX. #17746

Merged

6 tasks

jgmoore-or marked this pull request as ready for review April 1, 2026 20:03

jgmoore-or requested a review from kjacque April 1, 2026 20:03

kjacque requested changes Apr 2, 2026

View reviewed changes

jgmoore-or requested a review from phender April 10, 2026 18:52

DAOS-15518 control: Fix dmg network scan for UCX.

715c589

Test-provider: ucx+dc_x Skip-func-hw-test-medium-verbs-provider: true Skip-func-test-vm: true Allow-unstable-test: true Signed-off-by: Joseph Moore <joseph.moore@hpe.com>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DAOS-15518 control: Fix dmg network scan for UCX.#17636

DAOS-15518 control: Fix dmg network scan for UCX.#17636
jgmoore-or wants to merge 21 commits intomasterfrom
jgm/DAOS-15518

jgmoore-or commented Mar 3, 2026

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

daosbuild3 commented Mar 3, 2026

Uh oh!

daosbuild3 commented Mar 4, 2026

Uh oh!

daosbuild3 commented Mar 4, 2026

Uh oh!

daosbuild3 commented Mar 4, 2026

Uh oh!

daosbuild3 commented Mar 4, 2026

Uh oh!

daosbuild3 commented Mar 22, 2026

Uh oh!

kjacque left a comment

Uh oh!

kjacque Apr 2, 2026

Uh oh!

jgmoore-or Apr 10, 2026

Uh oh!

kjacque Apr 2, 2026

Uh oh!

jgmoore-or Apr 10, 2026

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

jgmoore-or commented Mar 3, 2026

Steps for the author:

After all prior steps are complete:

Uh oh!

github-actions bot commented Mar 3, 2026

Uh oh!

daosbuild3 commented Mar 3, 2026

Uh oh!

daosbuild3 commented Mar 4, 2026

Uh oh!

daosbuild3 commented Mar 4, 2026

Uh oh!

daosbuild3 commented Mar 4, 2026

Uh oh!

daosbuild3 commented Mar 4, 2026

Uh oh!

daosbuild3 commented Mar 22, 2026

Uh oh!

kjacque left a comment

Choose a reason for hiding this comment

Uh oh!

kjacque Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

jgmoore-or Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

kjacque Apr 2, 2026

Choose a reason for hiding this comment

Uh oh!

jgmoore-or Apr 10, 2026

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants