feat: add a root page to groups for breadcrumb linking#85
Merged
Conversation
Add an optional rootPage (slug of a standalone generic page) on groups. Group page breadcrumbs link the group name to its root page when set, and the slug is propagated to existing pages' (draft)config on patch.
BatLeDev
force-pushed
the
feat-group-root-page
branch
from
42f7131 to
082cdcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an optional
rootPageto groups: the slug of a standalone generic page used as the group's root.Why: make the group name clickable in the breadcrumb of group pages, pointing to a free-content page acting as the group's root.
What changes:
rootPagefield on the group schema, accepted on group creation and updategroup-formcomponent (mode: create | edit), instantiated twice inpages-actionsrootPageto theconfiganddraftConfigof the group's pages/pages/<rootPage>when setRegression risks:
rootPage, the group name stays a plain label (unchanged behavior)updateManyacross all of the group's pages wheneverrootPagechangespages-actionsdrops the unusedcurrentGroupIdprop andrefresh-groupemit (dead code; the only consumer never used them)