fix(ui): scope reuse-submit notifications by department#87
Draft
BatLeDev wants to merge 1 commit into
Draft
Conversation
Root accounts subscribe with :* to receive submissions from every portal of the org (root + departments), while a department-scoped account only subscribes to its own department, avoiding cross-department leakage. This is possible now that the events service supports the :* wildcard on the subscription side.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
:*and receive reuse submissions from every portal of the organization (root + departments).Why: possible now that the events service matches the
:*wildcard on the subscription side. Emission already carried the portal's real department.Heads-up: an events subscription's identity includes the
senderstring; switching from:*to:departmentcreates a new subscription and orphans the old one. Existing subscribers will need to re-subscribe.