feat(portal): show source data update date on application page#88
Draft
BatLeDev wants to merge 2 commits into
Draft
feat(portal): show source data update date on application page#88BatLeDev wants to merge 2 commits into
BatLeDev wants to merge 2 commits into
Conversation
…ate date dayjs(undefined) returns the current date, so datasets with neither modified nor dataUpdatedAt (e.g. meta-only) silently showed today. Fall back to the always-present updatedAt and use a generic 'last update' label when no data update date is available.
Display 'Données mises à jour le' under the owner, computed as the most recent modified/dataUpdatedAt across the application's source datasets, and relabel the application's own date as 'Visualisation mise à jour le'. The line is hidden when no source dataset exposes a data update date.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show the source data's last-update date on an application's page, next to the visualization's own update date.
modified, falling back todataUpdatedAt— matching data-fair's_modifiedfallback) and passes it toapplication-metadata.updatedAtlabel is clarified: "Visualization updated at" vs the new "Data updated at".dataset-metadata, which displayed today's date when a dataset had no update date: it now falls back toupdatedAtand uses a generic "Last update" label in that case.Heads-up: the existing
updatedAtlabel text changes ("Updated at" → "Visualization updated at") anddataset-metadata's display logic is modified — it's a shared component, so check the dataset pages too.