feat(ui): use shared useAutoScrollBottom from lib-vue on run page#104
Merged
Conversation
BatLeDev
force-pushed
the
feat-auto-scroll-bottom
branch
3 times, most recently
from
72596a5 to
b9611a2
Compare
BatLeDev
force-pushed
the
feat-auto-scroll-bottom
branch
from
b9611a2 to
63f4b86
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace the local
use-follow-bottomcomposable with the shareduseAutoScrollBottomfrom@data-fair/lib-vue(released in 1.28.0) on the run page, and raise the lib-vue floor to^1.28.0.Why: mutualize the run-log stick-to-bottom scroll logic into the shared lib so it can be reused — the agents chat now uses the same composable.
Regression risks:
useScroll(window)+ wheel-up handling +document.scrollingElementpin); the path worth a QA pass is the d-frame iframe embed the old comment specifically called out — confirm the log still pins to the tail there.@data-fair/lib-vuefloor raised^1.27.1→^1.28.0; resolves only against the published 1.28.0.