Skip to content

ci: post evals-monitor link comment on new PRs#430

Merged
calvarjorge merged 4 commits into
mainfrom
jorge_calvar/eval_pr_comment
Jun 22, 2026
Merged

ci: post evals-monitor link comment on new PRs#430
calvarjorge merged 4 commits into
mainfrom
jorge_calvar/eval_pr_comment

Conversation

@calvarjorge

@calvarjorge calvarjorge commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

What

Posts a small, one-time comment on every opened/reopened PR linking to the evals-monitor PR page, where the author can start an eval for their PR.

The comment renders as:

🧪  Run evals on this PR  ·  Start eval →

Why this approach

The staging workspace cannot be reached from the CI.

Details

  • Triggers on pull_request opened/reopened (targeting main).
  • Idempotent: checks for a <!-- pr-eval-link --> marker and skips if already present, so reopen won't double-post.

Add a workflow that comments once on each opened/reopened PR with a small
link to the evals-monitor PR page, where the author can start an eval.
This replaces the direct CI-trigger approach (see closed #428): GitHub
Actions runners can't reach the dogfood.staging workspace, so the app —
which runs inside dogfood — performs the actual trigger instead.

Co-authored-by: Isaac
Signed-off-by: Jorge Calvar <jorge.calvar@databricks.com>
…ink)

Co-authored-by: Isaac
Signed-off-by: Jorge Calvar <jorge.calvar@databricks.com>
@databricks databricks deleted a comment from github-actions Bot Jun 9, 2026
@calvarjorge calvarjorge closed this Jun 9, 2026
@calvarjorge calvarjorge reopened this Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

🔬  Run evals on this PR  ·  Go to Evals Monitor →

@calvarjorge calvarjorge requested a review from pkosiec June 22, 2026 14:38
@calvarjorge calvarjorge marked this pull request as ready for review June 22, 2026 14:46
@calvarjorge calvarjorge requested a review from a team as a code owner June 22, 2026 14:46

@pkosiec pkosiec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - just please address the concurrency issue

Comment thread .github/workflows/eval-pr-comment.yml
Comment thread .github/workflows/eval-pr-comment.yml
Add a per-PR concurrency group (cancel-in-progress: false) so a rapid
open+reopen can't race the marker check and double-post. Skip fork PRs,
whose read-only GITHUB_TOKEN can't comment and for whom the internal
evals-monitor link is useless anyway.

Co-authored-by: Isaac
Signed-off-by: Jorge Calvar <jorge.calvar@databricks.com>
@calvarjorge calvarjorge merged commit 094f9dd into main Jun 22, 2026
9 checks passed
@calvarjorge calvarjorge deleted the jorge_calvar/eval_pr_comment branch June 22, 2026 15:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants