Skip to content

feat(build): Maven POM cosmetics#1865

Merged
kingthorin merged 5 commits into
datafaker-net:mainfrom
spannm:feat/maven-pom-cosmetics
Jun 29, 2026
Merged

feat(build): Maven POM cosmetics#1865
kingthorin merged 5 commits into
datafaker-net:mainfrom
spannm:feat/maven-pom-cosmetics

Conversation

@spannm

@spannm spannm commented Jun 29, 2026

Copy link
Copy Markdown
Contributor

Description:

This PR makes subtle optimizations to pom.xml in order to improve developer experience, build flexibility, and maintenance.

The changes are split into separate, self-contained commits. This allows you to review and cherry-pick (or drop) specific improvements independently, depending on what should be adopted.

Changes:

  • Added Default Goal: Defined <defaultGoal>clean verify</defaultGoal> to enable full lifecycle builds via a simple mvn execution.
  • Modernized Java Setup: Replaced outdated source/target options with the modern <release> compiler configuration.
  • Flexible Enforcer Rules: Refactored Enforcer rules to use range-based versions ([17,)), allowing builds with newer JDKs (e.g., Java 21) while ensuring minimum requirements.
  • Dependency Management: Integrated versions-maven-plugin configured to filter out non-stable pre-releases (alpha, beta, rc, etc.) for streamlined dependency checks.
  • POM Clean-up: Centralized hardcoded plugin versions into properties and removed the obsolete <additionalparam> Javadoc property.

spannm added 5 commits June 29, 2026 18:41
Replace deprecated source/target options with maven-compiler-plugin's
'release' configuration. Decouple development and build JDK targets
by introducing explicit properties and relaxed range-based Enforcer
rules for minimum Java and Maven versions.
@codecov-commenter

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.56%. Comparing base (db65b75) to head (a440abb).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1865      +/-   ##
============================================
- Coverage     92.58%   92.56%   -0.02%     
+ Complexity     3565     3564       -1     
============================================
  Files           346      346              
  Lines          7050     7050              
  Branches        684      684              
============================================
- Hits           6527     6526       -1     
  Misses          363      363              
- Partials        160      161       +1     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@asolntsev asolntsev left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I guess :)

@asolntsev asolntsev added this to the 3.0.0 milestone Jun 29, 2026
@asolntsev asolntsev added enhancement New feature or request refactoring labels Jun 29, 2026
@kingthorin kingthorin merged commit 740895e into datafaker-net:main Jun 29, 2026
17 checks passed
@spannm spannm deleted the feat/maven-pom-cosmetics branch July 2, 2026 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request refactoring

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants