Calculate compressor ratio automatically#90
Open
petewarman wants to merge 5 commits intodavatron5000:masterfrom
Open
Calculate compressor ratio automatically#90petewarman wants to merge 5 commits intodavatron5000:masterfrom
petewarman wants to merge 5 commits intodavatron5000:masterfrom
Conversation
Owner
|
So whitespace nowrap, what if you wanted text to wrap to 2 lines but also wanted to maintain scalability? |
Author
|
Ah ok. That's a different use case to how I imagined this was used. The nowrap is just left in to get around the occasional rounding error in webkit. Shouldn't be too hard to find another way around that. Would also need to add in a multiline parameter to configure how many lines to break over. |
Author
|
So thinking about it - text wrapping doesn't provide equal length lines so multi line support is always going to require some manual tweaking. I've added in a scale factor which is used to determine what percentage of the width the text should occupy. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've added in a few lines in order to calculate correct compressor ratio on the fly rather than having to manually configure the plugin for each typeface.
Probably also worth pointing out that removing the compressor attribute changes the API.