Fix tab drop after the last tab in the strip#226
Merged
Conversation
The strip drop indicator always meant insert-before-the-hovered-tab, so the position after the last tab was unreachable and dropping in the strip's trailing empty space silently did nothing. - use the VS Code midpoint rule: the cursor's half of the hovered tab decides insert-before (left half) vs insert-after (right half) - the trailing empty space is now a drop target that appends - the end-of-strip position renders a right-edge indicator on the last tab; between-tab boundaries keep rendering as the next tab's left edge - drops commit the midpoint-adjusted index instead of the raw tab index
This was referenced Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Dragging a tab to the right of the last tab in a strip (e.g. after Diff/Explorer/Browser in the top bar) was impossible: the drop indicator always meant insert-before-the-hovered-tab, and the strip's trailing empty space was not a drop target, so drops there silently did nothing. This was flagged as a UX gap in the #224 review.
Now the strip follows the VS Code midpoint rule:
movePanel(dropping a tab on its own right half is a no-op, as expected).Type of Change
Checklist
pnpm typecheckandpnpm lintlocallyCritical Areas Modified