Skip to content

fix: avoid traces for deployment validation failures - #1951

Open
LautaroPetaccio wants to merge 2 commits into
mainfrom
fix/avoid-validation-log-traces
Open

fix: avoid traces for deployment validation failures#1951
LautaroPetaccio wants to merge 2 commits into
mainfrom
fix/avoid-validation-log-traces

Conversation

@LautaroPetaccio

Copy link
Copy Markdown
Contributor

Summary

  • log rejected deployments as warnings instead of errors
  • log failed deployment retries as warnings
  • prevent @well-known-components/logger from emitting synthetic console traces for expected validation failures

Verification

  • npm run build
  • npx eslint src/logic/deployments/component.ts src/logic/deployment-service/component.ts
  • npm run test:unit -- --runTestsByPath test/unit/ports/deployer.spec.ts --coverage=false
  • git diff --check

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant